Fix TrieMap#{filterInPlace,mapValuesInPlace} #9727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NthPortal
added
library:collections
|
currently an inefficient but simpler implementation. i'm working on a faster one, but... I think we should merge the reliable one first, and think about optimisation later |
|
oops I'm going to overengineer a test again 😬 |
johnynek
reviewed
Aug 16, 2021
NthPortal
force-pushed
the
topic/TrieMap-fixes-2/PR
branch
from
0882c14
to
c643485
Compare
|
@lrytz I think this has changed enough to need a re-review |
lrytz
force-pushed
the
topic/TrieMap-fixes-2/PR
branch
from
c643485
to
51a65b8
Compare
lrytz
approved these changes
Aug 23, 2021
test/junit/scala/collection/concurrent/ConcurrentMapTester.scala
Outdated
Show resolved
Hide resolved
NthPortal
force-pushed
the
topic/TrieMap-fixes-2/PR
branch
from
51a65b8
to
d0fcd15
Compare
Fix the behaviour of `concurrent.Map#filterInPlace` and `concurrent.Map#mapValuesInPlace` to respect atomic entry changes.
lrytz
force-pushed
the
topic/TrieMap-fixes-2/PR
branch
from
d0fcd15
to
b13ebd7
Compare
|
@NthPortal the Scala community build (plus the problem is reproducible by cloning https://github.com/twitter/util and running do you have time to dig into it...? |
|
that's really bad. but also how??? yeah, I'll look into it |
|
oh noooooooooooo |
NthPortal
commented
Aug 26, 2021
|
followup: #9737 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the behaviour of
TrieMap#filterInPlaceandTrieMap#mapValuesInPlaceto respect atomic entry changes.Built on top of #9726
Fixes scala/bug#12443