Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specialized ValueOf #9787

Closed
wants to merge 2 commits into from
Closed

specialized ValueOf #9787

wants to merge 2 commits into from

Conversation

jxnu-liguobin
Copy link
Member

@scala-jenkins scala-jenkins added this to the 2.13.7 milestone Oct 13, 2021
@jxnu-liguobin jxnu-liguobin changed the title feature req: specialized singleton types and valueOf #11489 specialized ValueOf Oct 13, 2021
@jxnu-liguobin
Copy link
Member Author

The VerifyError error was obtained. Did it lead to binary incompatibility? @SethTisue

@SethTisue SethTisue modified the milestones: 2.13.7, 2.13.8 Oct 26, 2021
@lrytz lrytz modified the milestones: 2.13.8, 2.13.9 Nov 18, 2021
@SethTisue
Copy link
Member

SethTisue commented Jan 20, 2022 •
edited

@jxnu-liguobin I think we passed over this because it's still marked as draft. I see that there isn't a VerifyError anymore. Do you believe this is ready for review?

The CI failure will go away if you squash/rebase into a single commit.

@jxnu-liguobin
Copy link
Member Author

@jxnu-liguobin I think we passed over this because it's still marked as draft. I see that there isn't a VerifyError anymore. Do you believe this is ready for review?

The CI failure will go away if you squash/rebase into a single commit.

I am not sure, the initial modification obtained verifyError, and then I abbreviated the scope of PR influence (making the conditions more stringent), but I'm not sure whether it is reasonable. So it didn't continue.

@SethTisue
Copy link
Member

Closing for inactivity, since this seems stalled. (As always, we can reopen a stale PR if activity resumes.)

@SethTisue SethTisue closed this Apr 20, 2022
@SethTisue SethTisue removed this from the 2.13.9 milestone Apr 20, 2022
@jxnu-liguobin jxnu-liguobin deleted the t11489 branch October 27, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@jxnu-liguobin @SethTisue @lrytz @scala-jenkins