Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer type of overridden member when inferring (under -Xsource:3) #9891

Merged
merged 1 commit into from
Feb 9, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/compiler/scala/tools/nsc/typechecker/Namers.scala
Original file line number Diff line number Diff line change
Expand Up @@ -1126,9 +1126,10 @@ trait Namers extends MethodSynthesis {
case ddef: DefDef if tree.symbol.isTermMacro => defnTyper.computeMacroDefType(ddef, pt)
case _ => defnTyper.computeType(tree.rhs, pt)
}

val defnTpe = dropIllegalStarTypes(widenIfNecessary(tree.symbol, rhsTpe, pt))
tree.tpt defineType defnTpe setPos tree.pos.focus
tree.tpt.defineType {
if (currentRun.isScala3 && !pt.isWildcard && pt != NoType && !pt.isErroneous) pt
else dropIllegalStarTypes(widenIfNecessary(tree.symbol, rhsTpe, pt))
}.setPos(tree.pos.focus)
tree.tpt.tpe
}

Expand Down
15 changes: 15 additions & 0 deletions test/files/pos/t7212.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@

// scalac: -Xsource:3

class A {
def f: Option[String] = Some("hello, world")
def remove(): Unit = ()
}
class B extends A {
override def f = None
override def remove() = ???
}
class C extends B {
override def f: Option[String] = Some("goodbye, cruel world")
override def remove(): Unit = println("removed! (not really)")
}
6 changes: 6 additions & 0 deletions test/files/pos/t7212b/JavaClient.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@

public class JavaClient extends ScalaThing {
public void remove() {
throw new UnsupportedOperationException();
}
}
4 changes: 4 additions & 0 deletions test/files/pos/t7212b/JavaThing.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@

public interface JavaThing {
default void remove() { throw new UnsupportedOperationException(); }
}
6 changes: 6 additions & 0 deletions test/files/pos/t7212b/ScalaThing.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@

// scalac: -Xsource:3

class ScalaThing extends JavaThing {
override def remove() = ???
}