Fix parsing of conditional expressions in parentheses (#19985)

We overlooked that the first parenthesized expression might be a tuple. See https://users.scala-lang.org/t/parsing-conditionals/9888
scala · Mar 20, 2024 · 0ea0eba · 0ea0eba
2 parents 4554131 + 767fc35
commit 0ea0eba
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/compiler/src/dotty/tools/dotc/parsing/Parsers.scala b/compiler/src/dotty/tools/dotc/parsing/Parsers.scala
@@ -2192,7 +2192,8 @@ object Parsers {
     def condExpr(altToken: Token): Tree =
       val t: Tree =
         if in.token == LPAREN then
-          var t: Tree = atSpan(in.offset) { Parens(inParens(exprInParens())) }
+          var t: Tree = atSpan(in.offset):
+            makeTupleOrParens(inParensWithCommas(commaSeparated(exprInParens)))
           if in.token != altToken then
             if toBeContinued(altToken) then
               t = inSepRegion(InCond) {

diff --git a/tests/pos/if-parse.scala b/tests/pos/if-parse.scala
@@ -0,0 +1,4 @@
+import scala.math.Ordering.Implicits.infixOrderingOps
+
+def test =
+  if (1, 2) < (3, 4) then 1 else 2