Harden NamedTuple handling against ill-formed NamedTuples

scala · Dec 5, 2023 · 97757f7 · 97757f7
1 parent fea5fe1
commit 97757f7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/compiler/src/dotty/tools/dotc/core/TypeUtils.scala b/compiler/src/dotty/tools/dotc/core/TypeUtils.scala
@@ -82,6 +82,7 @@ class TypeUtils {
         case defn.NamedTuple(nmes, vals) =>
           val names = nmes.tupleElementTypesUpTo(bound, normalize).getOrElse(Nil).map:
             case ConstantType(Constant(str: String)) => str.toTermName
+            case t => throw TypeError(em"Malformed NamedTuple: names must be string types, but $t was found.")
           val values = vals.tupleElementTypesUpTo(bound, normalize).getOrElse(Nil)
           names.zip(values)
         case t =>

diff --git a/tests/neg/named-tuples-3.scala b/tests/neg/named-tuples-3.scala
@@ -0,0 +1,7 @@
+import language.experimental.namedTuples
+
+def f: NamedTuple.NamedTuple[(Int, Any), (Int, String)] = ??? // error
+
+type Person = (name: Int, age: String)
+
+val p: Person = f