Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.3.1-RC5 Release procedure #18373

Closed
18 tasks done
Kordyjan opened this issue Aug 9, 2023 · 10 comments
Closed
18 tasks done

3.3.1-RC5 Release procedure #18373

Kordyjan opened this issue Aug 9, 2023 · 10 comments
Assignees
Labels
itype:meta Issues about process/similar

Comments

@Kordyjan
Copy link
Contributor

Kordyjan commented Aug 9, 2023

@Kordyjan Kordyjan added the itype:meta Issues about process/similar label Aug 9, 2023
@Kordyjan Kordyjan self-assigned this Aug 9, 2023
@soronpo
Copy link
Contributor

soronpo commented Aug 9, 2023

What is the policy regarding fixing known regressions before issuing yet another RC?

@He-Pin
Copy link

He-Pin commented Aug 9, 2023

So no features will be developed directly on 3.3.x but backpacking ?

@Kordyjan
Copy link
Contributor Author

@soronpo: We intend to fix everything that is a regression compared to any released version of the current LTS line (currently only 3.3.0). We do not prioritize fixing things that appeared in the versions before 3.3.0. What's more, in case fixing some regression from, let's say, 3.2.1, breaks any library build for 3.3, we are not backporting that fix to the LTS.

The list for this RC was prepared a few weeks ago. In the meantime, 400 new projects appeared in the Open CB. Based on them we can suspect that we have two more regressions to deal with. We will investigate. This may result in 3.3.1-RC6.

@soronpo
Copy link
Contributor

soronpo commented Aug 10, 2023

I found #18253 that started in 3.3.1-RCX
I also found another regression in 3.3.2-RCX, but it may appear in 3.3.1 depending on what is backported.

@soronpo
Copy link
Contributor

soronpo commented Aug 10, 2023

I found #18253 that started in 3.3.1-RCX

Oops, my mistake, it was 3.1.2-RCX

@soronpo
Copy link
Contributor

soronpo commented Aug 10, 2023

OK, now I see why I made the mistake. A change in 3.3.x caused this bug to appear.
@Kordyjan, what do you do in the following cases? I have a working code in 3.3.0 LTS, but changes in 3.3.1 caused two bugs. While trying to minimize those bugs, I found they were actually earlier regressions that were somehow masked under LTS. So for all intent and purpose, these regressions affect the LTS release, no? We won't be going back and reverting a compiler change that exposed those earlier bugs, right?
The issues I'm referring to are #18253 and #18263

@Kordyjan
Copy link
Contributor Author

Which case was that? Did some change in 3.3.1-RCx force you to change your code, and you bumped into something that should have been working and was working in previous versions but now doesn't? Or did the code just stop compiling after changing from 3.3.0 to 3.3.1-RCx, and then the minimization discovered some other (possibly related bug)?

In the first case, the thing that forced you to change the code is a regression; we will fix it when we learn more about it. In the second case this is either unrelated bug found during the minimization or the situation where two other bugs countered each other perfectly, and one of them were fixed. If this is the case we will either need to fix both of the issues or reintroduce the fixed bug to preserve compatibility.

@soronpo
Copy link
Contributor

soronpo commented Aug 10, 2023

My library compiled successfully under 3.3.0 (LTS). It fails to compile under 3.3.1-RCx. After minimizing the bugs (#18253 and #18263), the minimization also fails to work on earlier scalac versions. Somehow these bugs were canceled by some other compiler issues that were since resolved.

@soronpo
Copy link
Contributor

soronpo commented Aug 10, 2023

Another thing, why was #18214 not backported? It fixes a regression from 3.3.0, but it is marked for 3.4.x.

@Kordyjan
Copy link
Contributor Author

This being in the 3.4.0 milestone, only means that it is not backported yet, not that it will not be backported before the next RC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
itype:meta Issues about process/similar
Projects
None yet
Development

No branches or pull requests

3 participants