Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline TASTy jar has incorrect entry format on Windows #19681

Closed
bishabosha opened this issue Feb 13, 2024 · 0 comments · Fixed by #19690
Closed

Pipeline TASTy jar has incorrect entry format on Windows #19681

bishabosha opened this issue Feb 13, 2024 · 0 comments · Fixed by #19690
Assignees
@bishabosha
Labels
area:tooling itype:bug
Milestone
3.4.2

Comments

@bishabosha
Copy link
Member

the jar entries in the -Yjava-tasty-output jar on Windows have a backslash (\) to represent path separation, this is incorrect and forward slash (/) must always be used.

Compiler version

3.4.0-RC4

Notes

This flag is for testing purposes only, i.e. no interaction with the ecosystem.
@bishabosha bishabosha added itype:bug stat:needs triage Every issue needs to have an "area" and "itype" label area:tooling and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Feb 13, 2024
@bishabosha bishabosha self-assigned this Feb 13, 2024
@bishabosha bishabosha mentioned this issue Feb 13, 2024
Merged
bishabosha added a commit to scalacenter/scala that referenced this issue Feb 13, 2024
@bishabosha
Disable tasty pipelining tests on windows
baadd95 
These fail due to a bug in dotty,
see issue scala/scala3#19681
This was referenced Feb 13, 2024
Merged
Merged
bishabosha added a commit that referenced this issue Feb 14, 2024
@bishabosha
Java TASTy: use new threadsafe writer implementation (#19690)
e96cb18 
Also fix bug where Jar entries for -Yjava-tasty-output have backslash on
Windows.

Copies implementation from
`compiler/src/dotty/tools/backend/jvm/ClassfileWriters.scala`, but this
time I don't close the jar archive except from within Pickler (when its
more explicit that we wont write any longer to the early output jar), I
also no longer perform substitution of `.` by `/` in Pickler, instead
leave it to TastyWriter to decide how to process the classname.

fixes #19681
@Kordyjan Kordyjan added this to the 3.4.2 milestone Mar 28, 2024
@Kordyjan Kordyjan modified the milestones: 3.4.2, 3.5.0 May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bishabosha bishabosha

Labels
area:tooling itype:bug
Projects
None yet
Milestone
3.4.2
Development

Successfully merging a pull request may close this issue.

Java TASTy: use new threadsafe writer implementation dotty-staging/dotty
2 participants
@Kordyjan @bishabosha