Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable -Ycheck-init on community projects and CI #11385

Merged
merged 16 commits into from
Feb 25, 2021
Merged

Enable -Ycheck-init on community projects and CI #11385

merged 16 commits into from
Feb 25, 2021

Commits on Feb 24, 2021

  1. Remove unused file

    @liufengyun
    liufengyun committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    fbff070 View commit details
    Browse the repository at this point in the history

  2. Refactor check 

    - Make summary a proper class
- Rename isInternal to hasSource
- Refactor: remove useless parameter
- Split effect check into multiple methods
- Refactor ignored methods handling
  Ignore constructor call on Any, Object and AnyVal
- Fix missing return
    @liufengyun
    liufengyun committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    081aa78 View commit details
    Browse the repository at this point in the history

  3. Fix debugging code

    @liufengyun
    liufengyun committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    93a8184 View commit details
    Browse the repository at this point in the history

  4. Don't produce duplicate select effect in potential expansion

    @liufengyun
    liufengyun committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    e3de5ac View commit details
    Browse the repository at this point in the history

  5. Revert scala#9673 

    Handle NoPrefix properly
    @liufengyun
    liufengyun committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    7910e35 View commit details
    Browse the repository at this point in the history

  6. check initialization in community build

    @liufengyun
    liufengyun committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    322f4d0 View commit details
    Browse the repository at this point in the history

  7. Use correct owner for summarizing effects in parent calls

    @liufengyun
    liufengyun committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    7f03121 View commit details
    Browse the repository at this point in the history

  8. Fix crash: ensure class type is applied 

    Otherwise, looking up members will crash the compiler
    @liufengyun
    liufengyun committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    1b20194 View commit details
    Browse the repository at this point in the history

  9. Fix stdlib CB: don't check language patches 

    The owners are different for the patches, and they are always safe.
    @liufengyun
    liufengyun committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    8ed8887 View commit details
    Browse the repository at this point in the history

  10. Suppress warning in shapeless 

    Shapeless enabled `-Xfatal-warings`, the warnings make the CI fail.
    @liufengyun
    liufengyun committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    500083c View commit details
    Browse the repository at this point in the history

  11. Restore tests

    @liufengyun
    liufengyun committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    16c8bfa View commit details
    Browse the repository at this point in the history

  12. Fix CI: ignore export clause

    @liufengyun
    liufengyun committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    91c0f56 View commit details
    Browse the repository at this point in the history

  13. Set defTree properly 

    In the following test:

- tests/pos/i3130b.scala

If we add `transparent`, then everything is OK.
The reason is that we set `Symbol.defTree` systematically
in PostTyper. Now the inlining happens after PostTyper,
thus `defTree` is not properly set for inlined definitions.

To compensate, we ensure that `defTree` is set in the ReTyper.
The IninerTyper extends ReTyper, thus it fixes the problem.
Doing the fix directly in InlinerTyper, however, does not pass
the CI. The reason is that `-Ycheck:all` will run `TreeChecker`
which will make tree bindings get lost.
    @liufengyun
    liufengyun committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    0f034aa View commit details
    Browse the repository at this point in the history

  14. Disable -Ycheck-init for cats due to -Xfatal-warnings 

    cats enables -Xfatal-warnings and we don't want to change the library
to create conflicts with upstream.
    @liufengyun
    liufengyun committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    e4efda8 View commit details
    Browse the repository at this point in the history

  15. Address review

    @liufengyun
    liufengyun committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    3a6b0c8 View commit details
    Browse the repository at this point in the history

  16. Revert changes to shapeless 

    To avoid unnecessary conflicts, we disable -Ycheck-init on shapeless.
    @liufengyun
    liufengyun committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    db19f60 View commit details
    Browse the repository at this point in the history