Implement most of the Scala.js IR code generator. #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whether a language SAM type is also a valid SAM type for the back-end is a platform-specific thing. On Scala.js, for example, the rules are completely different than for the JVM. This commit therefore moves the logic of the predicate used by ExpandSAMs to decide whether to expand a SAM as an anonymous class to the Platform.
|
Review by @DarkDimius |
sjrd
force-pushed
the
scalajs-gen-exprs
branch
3 times, most recently
from
ac6067c
to
94bc01a
Compare
|
Addressed @smarter's comments from sjrd@d5a637d |
Notable things that are missing at this point: * Pattern matching * Try * Most of the JavaScript interop
|
@DarkDimius Done. I separated the JS interop stuff in a separate commit. Now each commit shows a correct diff. If you want I can even remove the JS interop commit from this PR, and bring it back in a follow up PR. As you prefer. |
Notable things that are not yet implemented: * JS exports * Scala.js-defined JS classes.
|
Otherwise LGTM |
|
@DarkDimius Updated. I declared caches for the phases, and I added more documentation explaining what you commented on. |
odersky
added a commit
that referenced
this pull request
Mar 18, 2016
Implement most of the Scala.js IR code generator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable things that are missing at this point:
Otherwise, the code generator is pretty complete. It is able to correctly compile and link a modified version of the Reversi demo (modified not to use any pattern matching).