Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TermParamClause.isGiven #12042

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Add TermParamClause.isGiven #12042

merged 1 commit into from
Apr 12, 2021

Conversation

nicolasstucki
Copy link
Contributor

Fixes #12021

Backport of #12025

@nicolasstucki nicolasstucki added this to the 3.0.0 milestone Apr 9, 2021
@nicolasstucki nicolasstucki changed the title Add TermParamClause.isGiven Add TermParamClause.isGiven Apr 9, 2021
@nicolasstucki nicolasstucki marked this pull request as ready for review April 12, 2021 07:29
liufengyun
liufengyun approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 4136eab into scala:release-3.0.0 Apr 12, 2021
@nicolasstucki nicolasstucki deleted the backport-#12025 branch April 12, 2021 14:01
@clhodapp
Copy link

One question: Why is it called isGiven when it is a using clause?

@nicolasstucki
Copy link
Contributor Author

nicolasstucki commented Apr 14, 2021 •
edited
Loading

Good question.

Because internally we represent symbols of parameters of using clause with the Given flag. This comes out of the TASTy format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
3.0.0-RC3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicolasstucki @clhodapp @liufengyun