Commits on Apr 15, 2021

1. Fix isInstanceOf[Array[?]] returning true on non-Array …

   Before this commit, the `MultiArrayOf(elem, ndims)` extractor used to
   strip wildcards from the element type, this was surprising since it does
   not match what the `ArrayOf(elem)` extractor does, and lead to a bug in
   `TypeTestCasts.interceptTypeApply` which contains the following code:
   
   case defn.MultiArrayOf(elem, ndims) if isGenericArrayElement(elem, isScala2 = false) =>
   
   `isGenericArrayElement` returns false for `Any` but true for
   `_ >: Nothing <: Any`, so the stripped wildcard means that this case was
   skipped, resulting in:
       x.isInstanceOf[Array[?]]
   being erased to:
       x.isInstanceOf[Object]
   instead of:
       scala.runtime.ScalaRunTime.isArray(x, 1)
   
   Fixed by tweaking `MultiArrayOf` to keep any final wildcard around like
   `ArrayOf` does.

   

   smarter committed Apr 15, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 4a384e7
   • Browse repository at this point

   Copy the full SHA

   4a384e7 View commit details

   Browse the repository at this point in the history