Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export constructor proxies #12311

Merged
merged 4 commits into from May 10, 2021
Merged

Export constructor proxies #12311

merged 4 commits into from May 10, 2021

Conversation

odersky
Copy link
Contributor

@odersky odersky commented May 2, 2021

Fixes #11229

@odersky odersky marked this pull request as draft May 2, 2021 17:42
It's awkward to delete all references to them. We should treat them like other
symbols that are effectively erased.
@odersky odersky marked this pull request as ready for review May 3, 2021 13:24
@odersky odersky requested a review from bishabosha May 3, 2021 13:24
@odersky
Copy link
Contributor Author

odersky commented May 3, 2021

This is best reviewed commit by commit, since each commit does something conceptually quite different from the others.

@nicolasstucki
Copy link
Contributor

Commit 56c40f8 has the wrong issue number. The issue was also ignored from the Linked issues.

When creating an exported type alias of a class that has a constructor proxy companion,
export an alias for that companion with it. The alias is again a constructor proxy.

Fixes scala#11229
Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bishabosha bishabosha enabled auto-merge May 10, 2021 18:22
@bishabosha bishabosha removed their assignment May 10, 2021
@bishabosha bishabosha merged commit ba6cb92 into scala:master May 10, 2021
@bishabosha bishabosha deleted the fix-12299 branch May 10, 2021 21:31
@Kordyjan Kordyjan added this to the 3.0.1 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no creator proxies for exported classes without a companion
4 participants