Syntax highlighting for REPL using ammonite as base instead of JLine #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixmulder
force-pushed
the
topic/repl-syntax-highlighting
branch
5 times, most recently
from
145c447
to
e7cc691
Compare
felixmulder
changed the title
felixmulder
force-pushed
the
topic/repl-syntax-highlighting
branch
3 times, most recently
from
bf5f854
to
4618297
Compare
|
Once #1238 is merged I believe this will compile under dotty. Side note: running only one test in the tests.scala file: |
One was implemted by hand and the other by using dotty's parser. The one built by hand is shorter, and behaves correctly. The scanner one is unfortunately not ready for testing - there are too many things that are workarounds for it to be a good solution as of now The code added from Ammonite is licensed under MIT, not sure where to put the license - but will add it once I know.
Since we decided to go with the non dotty-scanner approach these are unnecessary to have altered, might just as well revert them.
Launching the repl with: `runMain dotty.tools.dotc.repl.Main` is now working correctly
felixmulder
force-pushed
the
topic/repl-syntax-highlighting
branch
from
45d207a
to
3515901
Compare
|
@felixmulder You can rebase and try again. #1238 is merged. |
felixmulder
force-pushed
the
topic/repl-syntax-highlighting
branch
from
8fb9c11
to
f02cfda
Compare
felixmulder
force-pushed
the
topic/repl-syntax-highlighting
branch
from
f02cfda
to
29fc55a
Compare
When enter pressed immediately after keyword, the highlighting would be aborted
|
@odersky: there was a test that compiled dotty with |
|
@odersky, it would be nice to get this in before ScalaDays. |
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One was implemented by hand and the other by using dotty's scanner. The one
built by hand is ~short, and behaves correctly.
The scanner one is unfortunately not ready for testing - there are too
many things that are workarounds for it to be a good solution as of now
The code added from Ammonite is licensed under MIT, not sure where to
put the license - but will add it once I know.