Properly handle self-types in reflection member lookup #12893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
fix-reflect-members
branch
from
11a2c31
to
b335873
Compare
The type on which we lookup things needs to be the this-type of the class, otherwise it will not include members that only appear in the self-type, since these members can appear in the types of members of the current class, this could lead to a MissingType exception being thrown. Fixes scala#12081.
nicolasstucki
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type on which we lookup things needs to be the this-type of the
class, otherwise it will not include members that only appear in the
self-type, since these members can appear in the types of members of the
current class, this could lead to a MissingType exception being thrown.
Fixes #12081.
PS: as the documentation of
allMembersmention, it's an expensive method to call and it would be better to callmemberDenotswith a custom filter, but that's a bigger refactoring than I have time to tackle right now.