fix #12981 add REPL show diagnostics level warn | err #13000
Conversation
|
|
||
| @main | ||
| def run_insert_error(isModify: Boolean): Unit = | ||
| visitDirRecursively(replTestDir, isModify) |
There was a problem hiding this comment.
Nicely done :)
But we don't need to merge this into the repo.
There was a problem hiding this comment.
Thanks! 🥰
The reason that I committed it to the repo was that I realized that any change in REPL output will require similar hacks, to avoid a very tedious manual walkthrough of all tests, so this might be needed several times again, as the REPL output, err messages etc will improve over time to get in feature parity with the Scala 2 REPL.
I have moved the util to this repo for now so it is still on the internet if someone needs it again:
https://github.com/lunduniversity/introprog/tree/master/util/repl-output-update-tool
There was a problem hiding this comment.
Just pushed the delete and the checks are running...
There was a problem hiding this comment.
Let me know if there is a better place for this little repl-output-update hack to be discoverable to this community (?) and I'll contribute it there.
There was a problem hiding this comment.
There is --update-checkfiles which is passed via -D which should (be made to) work for REPL tests.
There was a problem hiding this comment.
Ok, feel free to use my util code for that if relevant.
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
|
@bishabosha Coloring looks nice (after temporarily commenting out fatal warnings in Build.sbt): |
you can also use this line in sbt shell to reset the compiler settings for the set `scala3-compiler-bootstrapped` / Compile / console / scalacOptions := Seq() // or whichever settings you want |
|
The community_build_a just failed here (but it went through before the color highlighting change, I think, so I'm curious if that really is the problem or the fail is unrelated?) |
|
That looks like flaky scalatest's tests failing:
I tried disabling them in 7556fd5 but somehow they're still being run? |
|
Aha. As long as their tests don't depend on color highlighting of REPL output then we're good :) |
See #12981