Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pick right type parameters for opaqueToBounds in TreeUnpickler #13206

Merged
merged 10 commits into from Jul 30, 2021
Merged

Pick right type parameters for opaqueToBounds in TreeUnpickler #13206

merged 10 commits into from Jul 30, 2021

Commits on Jul 30, 2021

  1. Pick right type parameters in TreeUnpickler 

    Fixes scala#13190
    @odersky
    odersky committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    336ec13 View commit details
    Browse the repository at this point in the history

  2. Strengthen argument type of opaqueToBounds

    @odersky
    odersky committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    3c6df35 View commit details
    Browse the repository at this point in the history

  3. Test for scala#12945

    @odersky
    odersky committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    714f847 View commit details
    Browse the repository at this point in the history

  4. Test for scala#13001

    @odersky
    odersky committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    09b06ef View commit details
    Browse the repository at this point in the history

  5. Pretty-print LambdaParams 

    Customized printer instead of falling back to toString
    @odersky
    odersky committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    882b141 View commit details
    Browse the repository at this point in the history

  6. Refactorings for clarity and to avoid unnecessary computation

    @odersky
    odersky committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    eadee84 View commit details
    Browse the repository at this point in the history

  7. Fix definition of Tensor in onnx-Scala 

    Type parameter Ax needs to be declared explicitly as covariant since Tensor is opaque.

This fell through the cracks before since under separate compilation type parameters
of opaque types got assigned structural variances. But this is incorrect. Under joint
compilation there would be an error.
    @odersky
    odersky committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    510aefc View commit details
    Browse the repository at this point in the history

  8. Test case for scala#12950

    @odersky
    odersky committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    565c5aa View commit details
    Browse the repository at this point in the history

  9. Test case for scala#13128

    @odersky
    odersky committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    f89ccf4 View commit details
    Browse the repository at this point in the history

  10. Test case for scala#12927

    @griggt
    griggt committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    6c2df3a View commit details
    Browse the repository at this point in the history