Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ordinal: drop unchecked with sealed abstract skips #13414

Closed
wants to merge 4 commits into from
Closed

ordinal: drop unchecked with sealed abstract skips #13414

wants to merge 4 commits into from

Commits on Sep 13, 2021

  1. ordinal: drop unchecked with sealed abstract skips 

    In the `ordinal` method, drop the use of `@unchecked` by skipping
children that are sealed traits or sealed abstract classes and don't
have any anonymous subclasses.

The `@unchecked` I added in ee5a82f.
In a PR to specifically with reachability I started similar warnings in
`ordinal` (this was before adding `@unchecked` was merged) so I'm hoping
with this patch to avoid the false positives properly.
    @dwijnand
    dwijnand committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    e9d88c7 View commit details
    Browse the repository at this point in the history

  2. In instantiateToSubType, also infer the prefix of the approximated pa… 

    …rent
    @dwijnand
    dwijnand committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    2b37f03 View commit details
    Browse the repository at this point in the history

  3. Add another variant of t6146, with double nesting and non-Any type args

    @dwijnand
    dwijnand committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    179909e View commit details
    Browse the repository at this point in the history

  4. ugh-next

    @dwijnand
    dwijnand committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    7d51ae0 View commit details
    Browse the repository at this point in the history