Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in initial support for code coverage #13880

Merged
merged 15 commits into from
Apr 13, 2022
Merged

Add in initial support for code coverage #13880

merged 15 commits into from
Apr 13, 2022

Commits on Apr 13, 2022

  1. Add in initial support for code coverage. 

    Co-Authored-By: Quentin Jaquier <q.jaquier@gmail.com>
    @ckipp01 @Qjaquier @smarter
    2 people authored and smarter committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    28bc87e View commit details
    Browse the repository at this point in the history

  2. Move coverage phase to before FirstTransform and handle more trees

    @TheElectronWill @smarter
    TheElectronWill authored and smarter committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    a4549e7 View commit details
    Browse the repository at this point in the history

  3. Improve Invoker performance with a BitSet 

    According to my JMH benchmarks, this improves the performance by at least 40%,
even when multiple threads use the Invoker.

Details on the benchmark:
- 10k calls to Invoker.invoked(id,dir) with a % of ids that are repeted in a loop and a % of ids that appear only
once. But this doesn't change the results much.
- 1 thread or 4 threads at the same time. The single-thread performance
is, as expected, much better (3x).
    @TheElectronWill @smarter
    TheElectronWill authored and smarter committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    b172922 View commit details
    Browse the repository at this point in the history

  4. Mark Invoker as sharable to bypass -Ycheck-reentrant

    @TheElectronWill @smarter
    TheElectronWill authored and smarter committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    d37d13b View commit details
    Browse the repository at this point in the history

  5. Cut coverage tests in small parts and avoid lifting literals

    @TheElectronWill @smarter
    TheElectronWill authored and smarter committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    cb66c7a View commit details
    Browse the repository at this point in the history

  6. Fix contexts in instrumentCoverage 

    Also add more tests and fix the remaining todo
    @TheElectronWill @smarter
    TheElectronWill authored and smarter committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    bad8b86 View commit details
    Browse the repository at this point in the history

  7. Standardize coverage tests 

    Now use
scala3-compiler-bootstrapped/testCoverage [--update-checkfiles]
    @TheElectronWill @smarter
    TheElectronWill authored and smarter committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    a8a6439 View commit details
    Browse the repository at this point in the history

  8. Fix coverage instrumentation for curried and context functions

    @TheElectronWill @smarter
    TheElectronWill authored and smarter committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    570aa50 View commit details
    Browse the repository at this point in the history

  9. Add aliases to coverage options

    @TheElectronWill @smarter
    TheElectronWill authored and smarter committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    9c01e86 View commit details
    Browse the repository at this point in the history

  10. Move Invoker to scala.runtime.coverage

    @TheElectronWill @smarter
    TheElectronWill authored and smarter committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    0d9bf9a View commit details
    Browse the repository at this point in the history

  11. Check the runtime output of some coverage tests

    @TheElectronWill @smarter
    TheElectronWill authored and smarter committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    c2bc0a0 View commit details
    Browse the repository at this point in the history

  12. Cleanup coverage instrumentation

    @TheElectronWill @smarter
    TheElectronWill authored and smarter committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    a1d0e64 View commit details
    Browse the repository at this point in the history

  13. Make Trees.transformCtx return the local context if needed

    @TheElectronWill @smarter
    TheElectronWill authored and smarter committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    169593d View commit details
    Browse the repository at this point in the history

  14. Ensure that cases and DefDefs are always instrumented for coverage

    @TheElectronWill @smarter
    TheElectronWill authored and smarter committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    3f71cd7 View commit details
    Browse the repository at this point in the history

  15. Make testCompilation run coverage tests

    @TheElectronWill @smarter
    TheElectronWill authored and smarter committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    2fc33a3 View commit details
    Browse the repository at this point in the history