Handle generic tuples when inlining #14209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-#14182
branch
6 times, most recently
from
87e76a9
to
8d8ef51
Compare
nicolasstucki
commented
Jan 5, 2022
| // If we take the `tree1` then it is impossible to select the `_1` field. If we take the parameter type we can lose singletons references that we should keep. | ||
| // Ideally we should ascribe it to a `tup.type & Tuple2[Int, Int]` but that is not working because we have the some special sub-typing rule that makes | ||
| // `1 *: 2 *: EmptyTuple <:< Tuple2[Int, Int]`. Therefore the glb of the two types ends up being `tup.type` which drops the extra information we need to add. | ||
| // None of the following attempts work. |
There was a problem hiding this comment.
@odersky do you have any idea how we could make this work?
There was a problem hiding this comment.
An alternative would be to teach member resolution that if we have a generic tuple with a known size that erases to TupleN it has the members of that TupleN class. For example a Int *: EmptyTuple would have the member _1 because it has the members of TupleN.
There was a problem hiding this comment.
This member selection issue is not contained in inlining. It was fairly straightforward to reproduce using type parameters in #14215.
There was a problem hiding this comment.
@odersky said to look at
Line 3848 Typer: pt match
case pt: SelectionProto =>
insert type ascription and readapt
nicolasstucki
force-pushed
the
fix-#14182
branch
2 times, most recently
from
daf7eba
to
5e342ad
Compare
nicolasstucki
force-pushed
the
fix-#14182
branch
from
5e342ad
to
28187d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14182