-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make by-name types first-class value types #14225
Closed
Closed
Commits on Jan 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 582228b - Browse repository at this point
Copy the full SHA 582228bView commit details
Commits on Jan 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3908fe2 - Browse repository at this point
Copy the full SHA 3908fe2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 937c9d0 - Browse repository at this point
Copy the full SHA 937c9d0View commit details -
I tried to extend specialization to all context functions, not just ones of 0 arity. But that runs into problems for dependent context functions, since the necessary casts get complicated. Since context functions over primitive types are an anti-pattern anyway I don't think we need to optimize this case, after all.
Configuration menu - View commit details
-
Copy full SHA for db05a36 - Browse repository at this point
Copy the full SHA db05a36View commit details -
Avoid using changeOwner in ByNameLambda
The regular changeOwner can cause cycles in transformations. Transformations like ByNameLambda should use the less demanding changeOwnerAfter.
Configuration menu - View commit details
-
Copy full SHA for 8fe40ca - Browse repository at this point
Copy the full SHA 8fe40caView commit details -
Fix handling of by-name default getters
There was an omission before, but as long as byname parameters were ExprTypes it did not lead to problems.
Configuration menu - View commit details
-
Copy full SHA for 63f7dba - Browse repository at this point
Copy the full SHA 63f7dbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 40c6e70 - Browse repository at this point
Copy the full SHA 40c6e70View commit details -
Instead, drop <by-name> applications when pickling and reconstitute them based on formal parameter types when unpickling.
Configuration menu - View commit details
-
Copy full SHA for 8371dfc - Browse repository at this point
Copy the full SHA 8371dfcView commit details
Commits on Jan 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 80987df - Browse repository at this point
Copy the full SHA 80987dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for a447a7e - Browse repository at this point
Copy the full SHA a447a7eView commit details
Commits on Jan 19, 2022
-
Move ElimRepeated miniphase to an earlier group
ByNameLambda needs to run in a group after ElimRepeated since ElimRepeated works on ByName arguments but not converted closures, and it sees the arguments after transformations by subsequent miniphases in the same group.
Configuration menu - View commit details
-
Copy full SHA for 3f51f11 - Browse repository at this point
Copy the full SHA 3f51f11View commit details -
Separate tree nodes for ByNames
ByName nodes in arguments are not pickled, which means that we can use the same Tasty version as before.
Configuration menu - View commit details
-
Copy full SHA for b7e5e57 - Browse repository at this point
Copy the full SHA b7e5e57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 733e20f - Browse repository at this point
Copy the full SHA 733e20fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 46c6a6a - Browse repository at this point
Copy the full SHA 46c6a6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f8b24b - Browse repository at this point
Copy the full SHA 5f8b24bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2066020 - Browse repository at this point
Copy the full SHA 2066020View commit details -
- Handle combinations of NamedArg and ByName - Accept and evaluate any remainign ByName applications
Configuration menu - View commit details
-
Copy full SHA for 00091c5 - Browse repository at this point
Copy the full SHA 00091c5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.