Fix 12919 - summon anonymous mirror when companion is a case object #14986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not very familiar with the mechanisms of mirror generation, perhaps @dwijnand could review this? |
bishabosha
changed the title
|
It would be nice if this change would allow for this #14136 in the future. |
dwijnand
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12919
closes #15101
There were two alternatives to solve this:
The first option will result in less code generation, however it will change the parent types of the companion from
Mirror.Singletonto eitherMirror.ProductorMirror.Sum(and change signatures offromProductorordinalin the companion), the second option will result in more code generation, but will preserve the signatures of the companion in bytecode for existing code.