Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for -scala-output-version flag #15146

Merged
merged 6 commits into from May 17, 2022

Conversation

Kordyjan
Copy link
Contributor

@Kordyjan Kordyjan commented May 9, 2022

No description provided.

docs/sidebar.yml Outdated Show resolved Hide resolved
@SethTisue
Copy link
Member

should this be milestoned for 3.2.0-RC1?

@Kordyjan Kordyjan force-pushed the remove-scala-output-version branch 3 times, most recently from 4eccd16 to 0a900f1 Compare May 17, 2022 11:58
Copy link
Contributor

@pikinier20 pikinier20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the report from the script that checks links stability:

Testing links stability in documentation
1990,1992c1990
< ./docs/reference/language-versions/binary-compatibility.html
< ./docs/reference/language-versions/index.html
< ./docs/reference/language-versions/source-compatibility.html
---
> ./docs/reference/language-versions.html

So basically, no pages are lost besides these that were added for -scala-output-version

@bishabosha
Copy link
Member

bishabosha commented May 17, 2022

This is the report from the script that checks links stability:

Testing links stability in documentation
1990,1992c1990
< ./docs/reference/language-versions/binary-compatibility.html
< ./docs/reference/language-versions/index.html
< ./docs/reference/language-versions/source-compatibility.html
---
> ./docs/reference/language-versions.html

please could we keep these pages, only some of the information in binary-compatibility.html needs to be removed

Edit: they are now kept, thanks!

@Kordyjan Kordyjan force-pushed the remove-scala-output-version branch from 144dade to d79602a Compare May 17, 2022 13:23
@Kordyjan
Copy link
Contributor Author

@bishabosha @julienrf
I indeed was too heavy-handed in reverting changes to the documentation. It should be better now.

@Kordyjan Kordyjan requested a review from julienrf May 17, 2022 14:58
Copy link
Collaborator

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only reviewed the changes that impact the reference documentation.

@Kordyjan Kordyjan enabled auto-merge May 17, 2022 15:11
@Kordyjan Kordyjan merged commit c5710d0 into scala:main May 17, 2022
@Kordyjan Kordyjan deleted the remove-scala-output-version branch May 17, 2022 21:39
@Kordyjan
Copy link
Contributor Author

@smarter @sjrd
This PR removed a private annotation from the standard library, that was used to annotate few public symbols.
Do you think this may have some significant impact on compatibility?

@sjrd
Copy link
Member

sjrd commented May 18, 2022

No that will have no impact. The references to the annotation would only be found in the libraries that did define the annotation, given that it was private.

And even then, failing to resolve an annotation in existing binaries is not a hard error in the compiler.

@DavidGregory084
Copy link

DavidGregory084 commented May 26, 2022

Can I ask what's going on with this flag? It's being removed just after being renamed in #14606, and after work to support has begun in various projects, see e.g. com-lihaoyi/mill#1764 and sbt/sbt#6814.
Is there any discussion that I can read to catch up on these changes?

@Kordyjan
Copy link
Contributor Author

Kordyjan commented May 27, 2022

@DavidGregory084 The flag was experimental and supported only in one milestone release of SBT. After thoroughly discussing it, we have realized that not only will it be hard to maintain, but also it can be detrimental to the ecosystem. Therefore, we have removed it.

Our communication about removing the flag and our plans for long-term compatibility for Scala 3 is in the public review phase after a few rounds of internal feedback from people from EPFL, ScalaCenter, and VirtusLab. You can find it here. I hope it will be published at the very beginning of the following week.

@DavidGregory084
Copy link

Thanks @Kordyjan I will have a read!

@SethTisue
Copy link
Member

@Kordyjan Kordyjan modified the milestones: 3.2.0-RC1, 3.2.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet