Remove OldTastyInspector from scaladoc #17623
Conversation
nicolasstucki
force-pushed
the
remove-OldTastyInspector-from-scaladoc
branch
from
fd5273b
to
931e9f2
Compare
| val inspector = new ScaladocTastyInspector | ||
|
|
||
| val (tastyPaths, nonTastyPaths) = filePaths.partition(_.endsWith(".tasty")) | ||
| val (jarPaths, invalidPaths) = nonTastyPaths.partition(_.endsWith(".jar")) |
There was a problem hiding this comment.
As far as I could see, we do not have any tests that use JARs. Either we are missing a test or scaladoc unpack the JAR before hand. Unpacking the jar would be less efficient than reading the JAR directly.
| @@ -0,0 +1,33 @@ | |||
| // Copy of tasty-inspector/src/scala/tasty/inspector/Inspector.scala | |||
| // FIXME remove this copy of the file | |||
There was a problem hiding this comment.
The scaladoc project depends on scala3-tasty-inspector, but for some reason, some of the use cases do not include this dependency at runtime. It fails with Caused by: java.lang.ClassNotFoundException: scala.tasty.inspector.Inspector (see community-build and sbt-test/scripted). The previous version did not use the proper inspector classes either and therefore did not encounter this issue.
It is fine to have a copy of these files here for now, as it is equivalent to the current state. Someone will need to investigate and fix this issue later. I will open an issue for this.
Backports #17623 to the LTS branch. PR submitted by the release tooling.
Backports #17744 to the LTS branch. PR submitted by the release tooling.
No description provided.