Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid embedding SelectionProtos in Conversions #17755

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Avoid embedding SelectionProtos in Conversions #17755

merged 3 commits into from
Jun 6, 2023

Commits on Jun 2, 2023

  1. Avoid embedding SelectionProtos in Conversions

    @dwijnand
    dwijnand committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    c32adc2 View commit details
    Browse the repository at this point in the history

  2. Fix implicit type used for conversions, as seen from usage 

    Using the minimisation of the specs2 failure that occurred in CI, the
conversion desired is `Conversion[String, Bar.this.Data]`.  But if we
use the given's symbol info, we end up with the type `Conversion[String,
Foo.this.Data]` which the generated tree will fail to adapt to.

Using the widening of the implicit candidate's TermRef will yield a
method type, as seen from the right prefix - `Bar.this.Data`.
    @dwijnand
    dwijnand committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    2517f38 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Fixup, skip adapting to non-conversions, and all prototypes

    @dwijnand
    dwijnand committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    701254f View commit details
    Browse the repository at this point in the history