Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #17997: Handle intersection type as this type of super type #18069

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

liufengyun
Copy link
Contributor

Fix #17997: Handle intersection type as this type of super type

@liufengyun liufengyun requested a review from olhotak June 26, 2023 21:48
@liufengyun
Copy link
Contributor Author

/cc: @q-ata @EnzeXing Could you please review as well (I wasn't able to invite you as reviewers)? Thank you.

Copy link
Contributor

@olhotak olhotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

Co-authored-by: Ondřej Lhoták <olhotak@uwaterloo.ca>
@olhotak olhotak merged commit 588a0b1 into scala:main Jun 27, 2023
17 checks passed
@olhotak olhotak deleted the fix-17997 branch June 27, 2023 21:11
olhotak added a commit that referenced this pull request Jul 27, 2023
…checker (#18141)

Issue #17997 reported a minimized example that crashed the object
instance initialization checker. That checker was fixed in #18069.
However, a similar example also crashes the global object initialization
checker. This PR adds a test that exhibits this crash in the global
object initialization checker.
@Kordyjan Kordyjan added this to the 3.4.0 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler crash (ClassCastException) with -Ysafe-init
3 participants