Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refix avoid GADT casting with ProtoTypes #18085

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Jun 28, 2023

Revert #17755, refix #15867, fixes #18062

@dwijnand dwijnand linked an issue Jun 28, 2023 that may be closed by this pull request
@dwijnand dwijnand marked this pull request as ready for review June 28, 2023 17:59
@dwijnand dwijnand requested a review from odersky June 28, 2023 17:59
@odersky odersky merged commit f3787eb into scala:main Jun 28, 2023
17 checks passed
@odersky
Copy link
Contributor

odersky commented Jun 28, 2023

It seems to break the build. I get test failures when building scaladoc. Can you check?

https://mail.google.com/mail/u/0/#inbox/FMfcgzGsnLPWkTmpNdZTNsNFcRBSsHXv

@odersky
Copy link
Contributor

odersky commented Jun 28, 2023

Actually, it seems the same scaladoc error happens in other branches as well. So have to look elsewhere.

@dwijnand dwijnand deleted the fix-conv-proto branch June 29, 2023 08:27
@Kordyjan Kordyjan added this to the 3.4.0 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't construct extension method via implicit conversion
3 participants