Use -Yscala2-library-tasty to add Scala 2 lib TASTY to scalac (internal only) #18613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag only works on the `scala3-bootstrapped/scalac` in the dotty project. It is intended for internal testing. Currently it is a bit expensive to compile the Scala 2 library TASTy. One reason in for this is that we need to use `-Ycheck:all` when compiling it to make sure that `-Yscala2-stdlib` is working properly. We only allow `scala3-bootstrapped/scalac` and not `scalac` to have this dependency for two reasons. First, we do want to be able to compile and run `scalac` command fast to reduce development testing time. Second, we do not have a stable enough version of the Scala 2 library TASTy yet. We also do not enable the Scala 2 library TASTy by default on `scala3-bootstrapped/scalac` because we still need this command to test against the current version of the library. Stability is also a concern for this version of the command.
nicolasstucki
force-pushed
the
support-stdlib-tasty-in-scalac-in-dotty-project
branch
from
f104cb9
to
4d03e49
Compare
odersky
added a commit
that referenced
this pull request
Oct 3, 2023
Align with the `scala-library` and `dotty-library` nomenclature. Note that the name of the project/jar is already `scala2-library`. * `stdlib-bootstrapped` -> `scala2-library-bootstrapped` * `stdlib-bootstrapped-tasty` -> `scala2-library-tasty` * `stdlib-bootstrapped-tasty-tests` -> `scala2-library-tasty-tests` Based on #18613
nicolasstucki
changed the title
nicolasstucki
added a commit
to dotty-staging/dotty
that referenced
this pull request
Oct 17, 2023
Follow up name changes in scala#18615 and align with flag added in scala#18613.
|
Flag will be removed in #18730 |
bishabosha
added a commit
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag only works on the
scala3-bootstrapped/scalacin the dotty project. It is intended for internal testing.Currently it is a bit expensive to compile the Scala 2 library TASTy. One reason in for this is that we need to use
-Ycheck:allwhen compiling it to make sure that-Yscala2-stdlibis working properly.We only allow
scala3-bootstrapped/scalacand notscalacto have this dependency for two reasons. First, we do want to be able to compile and runscalaccommand fast to reduce development testing time. Second, we do not have a stable enough version of the Scala 2 library TASTy yet.We also do not enable the Scala 2 library TASTy by default on
scala3-bootstrapped/scalacbecause we still need this command to test against the current version of the library. Stability is also a concern for this version of the command.