Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error when reading class file with unknown newer jdk version #18618

Merged
merged 2 commits into from
Nov 3, 2023
Merged

error when reading class file with unknown newer jdk version #18618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f430e44
error when reading class file with unknown newer jdk version
bishabosha Sep 29, 2023
2183bf9
track JDK version only when runtime exception occurs
bishabosha Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 42 additions & 16 deletions compiler/src/dotty/tools/dotc/core/classfile/ClassfileParser.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,28 @@ import scala.compiletime.uninitialized

object ClassfileParser {

object Header:
opaque type Version = Long

object Version:
val Unknown: Version = -1L

def brokenVersionAddendum(classfileVersion: Version)(using Context): String =
if classfileVersion.exists then
val (maj, min) = (classfileVersion.majorVersion, classfileVersion.minorVersion)
val scalaVersion = config.Properties.versionNumberString
i""" (version $maj.$min),
| please check the JDK compatibility of your Scala version ($scalaVersion)"""
else
""

def apply(major: Int, minor: Int): Version =
(major.toLong << 32) | (minor.toLong & 0xFFFFFFFFL)
extension (version: Version)
def exists: Boolean = version != Unknown
def majorVersion: Int = (version >> 32).toInt
def minorVersion: Int = (version & 0xFFFFFFFFL).toInt

import ClassfileConstants._

/** Marker trait for unpicklers that can be embedded in classfiles. */
Expand Down Expand Up @@ -57,6 +79,20 @@ object ClassfileParser {
}
}

private[classfile] def parseHeader(classfile: AbstractFile)(using in: DataReader): Header.Version = {
val magic = in.nextInt
if (magic != JAVA_MAGIC)
throw new IOException(s"class file '${classfile}' has wrong magic number 0x${toHexString(magic)}, should be 0x${toHexString(JAVA_MAGIC)}")
val minorVersion = in.nextChar.toInt
val majorVersion = in.nextChar.toInt
if ((majorVersion < JAVA_MAJOR_VERSION) ||
((majorVersion == JAVA_MAJOR_VERSION) &&
(minorVersion < JAVA_MINOR_VERSION)))
throw new IOException(
s"class file '${classfile}' has unknown version $majorVersion.$minorVersion, should be at least $JAVA_MAJOR_VERSION.$JAVA_MINOR_VERSION")
Header.Version(majorVersion, minorVersion)
}

abstract class AbstractConstantPool(using in: DataReader) {
protected val len = in.nextChar
protected val starts = new Array[Int](len)
Expand Down Expand Up @@ -247,6 +283,7 @@ class ClassfileParser(
protected var classTParams: Map[Name, Symbol] = Map()

private var Scala2UnpicklingMode = Mode.Scala2Unpickling
private var classfileVersion: Header.Version = Header.Version.Unknown

classRoot.info = NoLoader().withDecls(instanceScope)
moduleRoot.info = NoLoader().withDecls(staticScope).withSourceModule(staticModule)
Expand All @@ -259,7 +296,7 @@ class ClassfileParser(
def run()(using Context): Option[Embedded] = try ctx.base.reusableDataReader.withInstance { reader =>
implicit val reader2 = reader.reset(classfile)
report.debuglog("[class] >> " + classRoot.fullName)
parseHeader()
classfileVersion = parseHeader(classfile)
this.pool = new ConstantPool
val res = parseClass()
this.pool = null
Expand All @@ -268,22 +305,11 @@ class ClassfileParser(
catch {
case e: RuntimeException =>
if (ctx.debug) e.printStackTrace()
val addendum = Header.Version.brokenVersionAddendum(classfileVersion)
throw new IOException(
i"""class file ${classfile.canonicalPath} is broken, reading aborted with ${e.getClass}
|${Option(e.getMessage).getOrElse("")}""")
}

private def parseHeader()(using in: DataReader): Unit = {
val magic = in.nextInt
if (magic != JAVA_MAGIC)
throw new IOException(s"class file '${classfile}' has wrong magic number 0x${toHexString(magic)}, should be 0x${toHexString(JAVA_MAGIC)}")
val minorVersion = in.nextChar.toInt
val majorVersion = in.nextChar.toInt
if ((majorVersion < JAVA_MAJOR_VERSION) ||
((majorVersion == JAVA_MAJOR_VERSION) &&
(minorVersion < JAVA_MINOR_VERSION)))
throw new IOException(
s"class file '${classfile}' has unknown version $majorVersion.$minorVersion, should be at least $JAVA_MAJOR_VERSION.$JAVA_MINOR_VERSION")
i""" class file ${classfile.canonicalPath} is broken$addendum,
| reading aborted with ${e.getClass}:
| ${Option(e.getMessage).getOrElse("")}""")
}

/** Return the class symbol of the given name. */
Expand Down
24 changes: 8 additions & 16 deletions compiler/src/dotty/tools/dotc/core/classfile/ClassfileTastyUUIDParser.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ import dotty.tools.dotc.util._
import dotty.tools.io.AbstractFile
import dotty.tools.tasty.TastyReader

import ClassfileParser.Header

import java.io.IOException
import java.lang.Integer.toHexString
import java.util.UUID
Expand All @@ -23,33 +25,23 @@ class ClassfileTastyUUIDParser(classfile: AbstractFile)(ictx: Context) {
import ClassfileConstants._

private var pool: ConstantPool = uninitialized // the classfile's constant pool
private var classfileVersion: Header.Version = Header.Version.Unknown

def checkTastyUUID(tastyUUID: UUID)(using Context): Unit = try ctx.base.reusableDataReader.withInstance { reader =>
implicit val reader2 = reader.reset(classfile)
parseHeader()
this.classfileVersion = ClassfileParser.parseHeader(classfile)
this.pool = new ConstantPool
checkTastyAttr(tastyUUID)
this.pool = null
}
catch {
case e: RuntimeException =>
if (ctx.debug) e.printStackTrace()
val addendum = Header.Version.brokenVersionAddendum(classfileVersion)
throw new IOException(
i"""class file ${classfile.canonicalPath} is broken, reading aborted with ${e.getClass}
|${Option(e.getMessage).getOrElse("")}""")
}

private def parseHeader()(using in: DataReader): Unit = {
val magic = in.nextInt
if (magic != JAVA_MAGIC)
throw new IOException(s"class file '${classfile}' has wrong magic number 0x${toHexString(magic)}, should be 0x${toHexString(JAVA_MAGIC)}")
val minorVersion = in.nextChar.toInt
val majorVersion = in.nextChar.toInt
if ((majorVersion < JAVA_MAJOR_VERSION) ||
((majorVersion == JAVA_MAJOR_VERSION) &&
(minorVersion < JAVA_MINOR_VERSION)))
throw new IOException(
s"class file '${classfile}' has unknown version $majorVersion.$minorVersion, should be at least $JAVA_MAJOR_VERSION.$JAVA_MINOR_VERSION")
i""" class file ${classfile.canonicalPath} is broken$addendum,
| reading aborted with ${e.getClass}:
| ${Option(e.getMessage).getOrElse("")}""")
}

private def checkTastyAttr(tastyUUID: UUID)(using ctx: Context, in: DataReader): Unit = {
Expand Down
Loading