Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align unpickled Scala 2 accessors encoding with Scala 3 #18874

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Align unpickled Scala 2 accessors encoding with Scala 3 #18874

merged 2 commits into from
Nov 16, 2023

Commits on Nov 10, 2023

  1. Move Scala 2 library tests from Windows into Linux

    @nicolasstucki
    nicolasstucki committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    032f6cd View commit details
    Browse the repository at this point in the history

  2. Align unpickled Scala 2 accessors encoding with Scala 3 

    Adapt the flags of getters so they become like vals/vars instead. The
getters flags and info are modified. The private fields for case
accessors are not unpickled anymore.

We need these getters to be aligned with Scala 3 if we want to be able
to use the Scala 2 library TASTy. Otherwise library classfiles would not
behave in the same way as their TASTy counterpart.

This change may cause some macros to fail if they relied on the old
style accessors. This should be adapted to work with the old and new
representation. We observed that such a change is needed in `verify`,
other might be detected with the open community build.
    @nicolasstucki
    nicolasstucki committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    d04b3c7 View commit details
    Browse the repository at this point in the history