Handle default implicits to context parameters under -3.4-migration #19512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synthesized calls for default implicits needed a using clause when the method was an implicit method, but had a context bound parameter in 3.4-migration. Also, we can't rewrite adding a `using` clause if the argument list is empty, since we are lacking precise position info. Fixes scala#19506
odersky
added
the
backport:nominated
|
If this can get still in before 3.4 RC3 is cut, I'd do it. If not it's OK to wait for 3.4.1. |
21 tasks
Kordyjan
approved these changes
Jan 23, 2024
Kordyjan
added
backport:accepted
WojciechMazur
added
backport:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synthesized calls for default implicits need a using clause when the method is an implicit method with a context bound parameter, but only in in 3.4-migration. Before this PR we still generated a normal empty parameter list.
Also, we can't rewrite adding a
usingclause if the argument list is empty, since we are lacking precise position info.Fixes #19506