Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GADT symbols when typing typing-ahead lambda bodies #19644

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Feb 7, 2024

Fixes #19570

@dwijnand dwijnand marked this pull request as ready for review February 19, 2024 15:03
@smarter smarter assigned dwijnand and unassigned smarter Feb 19, 2024
@dwijnand dwijnand assigned smarter and unassigned dwijnand Feb 22, 2024
@smarter
Copy link
Member

smarter commented Feb 22, 2024

What's the correct way to request a backport of this to 3.4.1-RC2?

@dwijnand
Copy link
Member Author

Why would reset the release train for this? Can't it just go in the next release?

@dwijnand dwijnand merged commit 98efdab into scala:main Feb 22, 2024
19 checks passed
@dwijnand dwijnand deleted the gadt-poly branch February 22, 2024 23:11
@smarter
Copy link
Member

smarter commented Feb 23, 2024

Because it fixes a regression. I don't think backporting fixes should require delaying the release: Rust does backport and never delays their releases (https://doc.rust-lang.org/book/appendix-07-nightly-rust.html), but I guess if this is our policy currently then not much point in backporting yeah.

@dwijnand
Copy link
Member Author

Good points.

@dwijnand dwijnand added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Feb 23, 2024
@Kordyjan Kordyjan added backport:done This PR was successfully backported. and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Mar 12, 2024
@Kordyjan Kordyjan added this to the 3.4.1 milestone Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:done This PR was successfully backported.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in GADT type inference inside polymorphic function
3 participants