Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry constraint.replace after constraint.updateEntry #20399

Merged
merged 4 commits into from
May 16, 2024

Commits on May 14, 2024

  1. Retry constraint.replace after constraint.updateEntry

    Checking `isSub` on the resulting bounds can have introduced new constraints,
    which might allow us to replace the type parameter entirely.
    EugeneFlesselle committed May 14, 2024
    Configuration menu
    Copy the full SHA
    49940ee View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Configuration menu
    Copy the full SHA
    97ed37e View commit details
    Browse the repository at this point in the history
  2. Do tryReplace using narrowedBounds instead of legalBound

    In scala#20120, we reach constraints with equal bounds that are intersection types,
    they are formed from multiple successive calls to `addOneBound`.
    
    We miss the `replace` optimization in this case because
    the bounds only become equal progressively, and
    we are only checking for equality with the constraint being added.
    
    The second tryReplace after updateEntry and isSub
    does not address this specific issue but scala#19955.
    EugeneFlesselle committed May 15, 2024
    Configuration menu
    Copy the full SHA
    14a6cac View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Fix doc position

    EugeneFlesselle committed May 16, 2024
    Configuration menu
    Copy the full SHA
    b1d7735 View commit details
    Browse the repository at this point in the history