Use sbt-native-packager instead of sbt-pack #20547
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
force-pushed
the
msi-installer
branch
8 times, most recently
from
88a77b7
to
59daf47
Compare
hamzaremmal
force-pushed
the
msi-installer
branch
9 times, most recently
from
5d50b44
to
3096410
Compare
hamzaremmal
force-pushed
the
msi-installer
branch
from
3096410
to
073ef51
Compare
hamzaremmal
force-pushed
the
msi-installer
branch
3 times, most recently
from
6eeb38f
to
7d59d4f
Compare
bishabosha
reviewed
Jul 2, 2024
bin/common
Outdated
|
|
||
| # Create the target if absent or if file changed in ROOT/compiler | ||
| new_files="$(find "$ROOT/compiler" \( -iname "*.scala" -o -iname "*.java" \) -newer "$version" 2> /dev/null)" | ||
|
|
||
| if [ ! -f "$version" ] || [ ! -z "$new_files" ]; then | ||
| echo "Building Dotty..." | ||
| (cd $ROOT && sbt "$DIST_PROJECT/pack") | ||
| (cd $ROOT && sbt "$DIST_PROJECT/Universal/packageBin") |
There was a problem hiding this comment.
this should be the stage task, looking at the similar changes in this commit
hamzaremmal
force-pushed
the
msi-installer
branch
from
7d59d4f
to
70fc581
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #20351.
The idea is to use
sbt-native-packagerinstead ofsbt-packsince it has the ability to generate.msifiles.[test_msi]