Upgrade to sbt 0.13.14-RC2, switch to build.sbt #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 for removing the unused scalastyle plugin |
smarter
force-pushed
the
upgrade/sbt0.13.14
branch
from
e19b6d5
to
b0e4afa
Compare
smarter
force-pushed
the
upgrade/sbt0.13.14
branch
from
a735328
to
a0e9060
Compare
smarter
changed the title
smarter
changed the title
smarter
force-pushed
the
upgrade/sbt0.13.14
branch
from
4e8427f
to
8bdac36
Compare
Also replace com.typesafe.sbt:sbt-interface by the equivalent org.scala-sbt:interface since the former is not published in 0.13.14 for some reason (sbt/sbt#3012).
Also fix a bug where the compiler output for the tests ended up in the wrong directory, causing some new tests from 0.13.14 to fail.
smarter
force-pushed
the
upgrade/sbt0.13.14
branch
from
8bdac36
to
e10a81f
Compare
Using the same technique than scala-js where we just forward to Build.scala: scala-js/scala-js#2312
smarter
force-pushed
the
upgrade/sbt0.13.14
branch
from
e10a81f
to
70c072a
Compare
|
@felixmulder I think this is ready to go in (even though sbt 0.13.14 is not released yet, this way we may be able to get potential issues fixed before the release) |
|
What about sbt/sbt#3012? |
|
Otherwise LGTM |
|
Using org.scala-sbt:interface is fine even with coursier as long as we add resolvers to all subprojects as explained in coursier/coursier#284 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's wait until sbt/sbt#3012 is fixed first.