Consider syntax with significant indentation #2488
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several uses of `with` in expressions, templates and package definitions.
Also, add a mode to `Source.column` that flags tab characters as -1 results.
Check that // end <ident> comments line up with preceding trees.
felixmulder
reviewed
May 20, 2017
| if (follow.isEmpty || ".;,".contains(follow.head)) str else "" | ||
| } | ||
| else "" | ||
|
|
There was a problem hiding this comment.
Does this add semantic meaning to comments?
There was a problem hiding this comment.
Not really, since you only get a warning if there's misalignment.
If a line contains several with's and ends in =>, pick the last with as the indentation point.
This got confused because we use case outside patterns. Fixed by having the parser tell the scanner when a pattern starts and ends. Note: The end comment syntax for enums does not work yet.
|
Closing this for now, see: #2491 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a trial balloon to test syntax that allows to optionally replace braces with indentation.
It implements #2491.
For the moment this is for experimentation only, no decision has been made to merge this.