Faster base class sets #2676
Merged
Faster base class sets #2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speed up construction and testing of base class sets. Use a linear search with automatic bubbling up of hits.
|
@DarkDimius, since you suggested the scheme, do you want to review it? |
|
Yes, gladly. Did you already do any measurements? |
|
I did not do any measurements yet. Jason did a similar change for scalac (minus the bubbling up part) and it gained them some speed there. |
DarkDimius
approved these changes
Jun 7, 2017
|
My hypothesis in scalac was that (part?) of the speedup was due to forcing fewer basetypeseqs, which we had to do to compute their length, part of the ordering criteria in the binary search. Here are some numbers measured before and after: scala/scala#5829 |
|
@DarkDimius I am helping @biboudis setup/manage the benchmark infrastructure. The benchmarks currently run an old 0.1-bin version, fix pending in #2690 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up construction and testing of base class sets.
Use a linear search with automatic bubbling up of
hits.