Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only start the Dotty VSCode extension if .dotty-ide.json exists #2777

Merged
merged 1 commit into from Jun 19, 2017

Conversation

smarter
Copy link
Member

@smarter smarter commented Jun 17, 2017

This avoids conflicts with other extensions like
https://github.com/dragos/dragos-vscode-scala

@smarter smarter requested a review from felixmulder June 17, 2017 17:59
smarter added a commit to smarter/dragos-vscode-scala that referenced this pull request Jun 17, 2017
The extension is useless without it, and this avoids conflicts with
other extensions like the Dotty Language Server (which will only start
when a .dotty-ide.json file is present after
scala/scala3#2777)
smarter added a commit to smarter/dragos-vscode-scala that referenced this pull request Jun 17, 2017
The extension is useless without it, and this avoids conflicts with
other extensions like the Dotty Language Server (which will only start
when a .dotty-ide.json file is present after
scala/scala3#2777)
@felixmulder felixmulder merged commit 888744f into scala:master Jun 19, 2017
dragos pushed a commit to dragos/dragos-vscode-scala that referenced this pull request Jun 20, 2017
The extension is useless without it, and this avoids conflicts with
other extensions like the Dotty Language Server (which will only start
when a .dotty-ide.json file is present after
scala/scala3#2777)
jc776 pushed a commit to jc776/dragos-vscode-scala that referenced this pull request Jun 20, 2017
The extension is useless without it, and this avoids conflicts with
other extensions like the Dotty Language Server (which will only start
when a .dotty-ide.json file is present after
scala/scala3#2777)
fede0664 pushed a commit to fede0664/dragos-vscode-scala that referenced this pull request Sep 9, 2017
The extension is useless without it, and this avoids conflicts with
other extensions like the Dotty Language Server (which will only start
when a .dotty-ide.json file is present after
scala/scala3#2777)
@allanrenucci allanrenucci deleted the ide-activation branch December 14, 2017 19:23
RonWelch0109 added a commit to RonWelch0109/ScDragos that referenced this pull request Dec 28, 2021
The extension is useless without it, and this avoids conflicts with
other extensions like the Dotty Language Server (which will only start
when a .dotty-ide.json file is present after
scala/scala3#2777)
RonWelch0109 added a commit to RonWelch0109/ScDragos that referenced this pull request Dec 28, 2021
The extension is useless without it, and this avoids conflicts with
other extensions like the Dotty Language Server (which will only start
when a .dotty-ide.json file is present after
scala/scala3#2777)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants