Fix #3383: Don't fail on unreported errors #3734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scala#3383 shows that there are valid cases where an error type is assigned to a tree before the error is reported. The error will then be reported later in `adapt`.
| assert(ctx.mode.is(Mode.Interactive) || ctx.reporter.errorsReported) | ||
| else if (Config.checkTreesConsistent) | ||
| if (Config.checkUnreportedErrors) | ||
| if (tpe.isInstanceOf[ErrorType]) assert(ctx.reporter.errorsReported) |
There was a problem hiding this comment.
Why drop the ctx.mode.is(Mode.Interactive)?
There was a problem hiding this comment.
No need I think. Since Config.checkUnreportedErrors is by default false, we don't need the additional test. If someone turns Config.checkUnreportedErrors on for the IDE I assume they know what they are doing.
| else if (Config.checkTreesConsistent) | ||
| if (Config.checkUnreportedErrors) | ||
| if (tpe.isInstanceOf[ErrorType]) assert(ctx.reporter.errorsReported) | ||
| if (Config.checkTreesConsistent) |
There was a problem hiding this comment.
Now, if tpe.isInstanceOf[ErrorType] is true we would go into this branch. Is this intentional?
There was a problem hiding this comment.
Good point. No, we need to fix that.
nicolasstucki
approved these changes
Jan 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3383 shows that there are valid cases where an error type is assigned to a tree
before the error is reported. The error will then be reported later in
adapt.