Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2732: Allow wildcards in SAM types (take 2) #4152

Merged
merged 3 commits into from
Mar 23, 2018
Merged

Fix #2732: Allow wildcards in SAM types (take 2) #4152

merged 3 commits into from
Mar 23, 2018

Commits on Mar 21, 2018

  1. Make the SAMType extractor return a type, not a denot

    @smarter
    smarter committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    83c3de7 View commit details
    Browse the repository at this point in the history

  2. Relax the SAMType#isInstantiable check 

    Narrowing the type is not necessary to check for instantiability, and it
prevents valid SAM types with wildcards from being used. This commit
does not contain any positive testcase because SAM types with wildcards
need another fix present in the next commit to work.
    @smarter
    smarter committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    d2fcfab View commit details
    Browse the repository at this point in the history

  3. Fix scala#2732: Allow wildcards in SAM types

    @smarter
    smarter committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    6127c5b View commit details
    Browse the repository at this point in the history