Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4984: support name-based unapplySeq #5078

Merged
merged 10 commits into from
Sep 20, 2018
Merged

Fix #4984: support name-based unapplySeq #5078

merged 10 commits into from
Sep 20, 2018

Commits on Sep 9, 2018

  1. Fix scala#4984: support name-based unapplySeq

    @liufengyun @allanrenucci
    liufengyun authored and allanrenucci committed Sep 9, 2018
    Configuration menu
    Copy the full SHA
    2a5e33f View commit details
    Browse the repository at this point in the history

  2. use toSeq type as element type and check type

    @liufengyun @allanrenucci
    liufengyun authored and allanrenucci committed Sep 9, 2018
    Configuration menu
    Copy the full SHA
    48b7dbb View commit details
    Browse the repository at this point in the history

  3. add neg test

    @liufengyun @allanrenucci
    liufengyun authored and allanrenucci committed Sep 9, 2018
    Configuration menu
    Copy the full SHA
    6999ca8 View commit details
    Browse the repository at this point in the history

  4. address review: try length if lengthCompare unavailable

    @liufengyun @allanrenucci
    liufengyun authored and allanrenucci committed Sep 9, 2018
    Configuration menu
    Copy the full SHA
    4c12ed3 View commit details
    Browse the repository at this point in the history

  5. add more tests

    @liufengyun @allanrenucci
    liufengyun authored and allanrenucci committed Sep 9, 2018
    Configuration menu
    Copy the full SHA
    3b93d98 View commit details
    Browse the repository at this point in the history

  6. fix failed test neg/i3248.scala

    @liufengyun @allanrenucci
    liufengyun authored and allanrenucci committed Sep 9, 2018
    Configuration menu
    Copy the full SHA
    9304ed6 View commit details
    Browse the repository at this point in the history

  7. update docs for name-based unapplySeq

    @liufengyun @allanrenucci
    liufengyun authored and allanrenucci committed Sep 9, 2018
    Configuration menu
    Copy the full SHA
    255c5bb View commit details
    Browse the repository at this point in the history

  8. address review

    @liufengyun @allanrenucci
    liufengyun authored and allanrenucci committed Sep 9, 2018
    Configuration menu
    Copy the full SHA
    94a93e5 View commit details
    Browse the repository at this point in the history

  9. fix ci: member types should go through asSeenFrom

    @liufengyun @allanrenucci
    liufengyun authored and allanrenucci committed Sep 9, 2018
    Configuration menu
    Copy the full SHA
    4d00b92 View commit details
    Browse the repository at this point in the history

  10. Cleanup + Documentation + More neg tests

    @allanrenucci
    allanrenucci committed Sep 9, 2018
    Configuration menu
    Copy the full SHA
    6a0fc8c View commit details
    Browse the repository at this point in the history