Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worksheet improvements #5230

Merged
merged 3 commits into from
Oct 10, 2018
Merged

Worksheet improvements #5230

merged 3 commits into from
Oct 10, 2018

Commits on Oct 9, 2018

  1. vscode-dotty: typesafe messages

    This replaces the use of strings for identifying messages by
    types (WorksheetExecRequest and WorksheetPublishOutputNotification).
    
    Also contains some light cleanup/uniformization
    smarter committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    214d1fe View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2018

  1. Refactor worksheet support, make it a dynamic feature

    - Only enable worksheet features on the client if the server supports
    them using the LSP support for dynamic feature registration.
    - Replace the global functions and state in worksheet.ts by a
    WorksheetProvider class, move some of the global functions specific to
    one worksheet into Worksheet
    smarter committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    0f465e5 View commit details
    Browse the repository at this point in the history
  2. Standardize vocabulary around running the worksheet

    We used interchangeably the term "run", "evaluate" and "exec" for
    talking about running a worksheet. This commit does a lot of renaming
    to standardize on using "run" everywhere.
    smarter committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    59ceea9 View commit details
    Browse the repository at this point in the history