Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Worksheet improvements #5277

Merged
merged 4 commits into from Oct 17, 2018
Merged

Worksheet improvements #5277

merged 4 commits into from Oct 17, 2018

Commits on Oct 17, 2018

  1. Use a CodeLens to run/cancel the worksheet 

    This makes it possible to run the worksheet without saving the document
or manually running the dotty.worksheet.run command. The new UI is also less
distracting since you don't get a notification pop-up every time the
worksheet is being run.
    @smarter
    smarter committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    9ed9357 View commit details
    Browse the repository at this point in the history

  2. Remove worksheet cancellation on document change 

    This is unreliable because we change the document by adding newlines
when we receive a multi-line result for a given line of the worksheet
    @smarter
    smarter committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    0ec624a View commit details
    Browse the repository at this point in the history

  3. Use a color that is theme-specific for the worksheet output 

    This way we can be sure that our output is readable in all themes.
    @smarter
    smarter committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    99ac060 View commit details
    Browse the repository at this point in the history

  4. Run worksheets asynchronously 

    A worksheet in an infinite loop shouldn't block the whole language
server from responding to queries. We just need to be careful to lock
the language server when operating on trees since these operations may
not be thread-safe (for example, when a symbol gets forced). We could
also allow running multiple worksheets at the same time but this commit
doesn't implement that.
    @smarter
    smarter committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    8c3319c View commit details
    Browse the repository at this point in the history