Implement non-local returns #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-local returns are now implemented.
Disable the check because if fails for desugar.scala and also in some dotty files. This test failed before the addition of NonLocalReturns.
After erasure, if required conformance is between value and non-value types, one should perform boxing and unboxing operations automatically, instead of just issuing a cast, which would be illegal at that point. Also: make isNonLocalReturn available as part of a global object, because we'll need it in LiftTry.
Phase lifts tries that would be illegal because they execute on non-empty expression stacks.
This reverts commit a43d39a.
This reverts commit c8afd79.
odersky
force-pushed
the
add/non-local/returns
branch
from
d9aacf6
to
694aabd
Compare
|
@DarkDimius Adding this as a post-condition is also not straightforward. I'd probably leave it as it is for now. |
|
I am going to merge now, because the PR contains a crucial fix for master. As it stands, master does not pass the tests (on my machine) because of the illegal name problem after labelDefs. Another question that needs to be investigated is why the checkin tests pass - they should fail as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement non-local returns and lift try expressions as necessary. Also, fix previous -Ycheck:labelDef failure by picking a different naming scheme for local dummies.
Closes #742, #743, and #747.
Review by @DarkDimius