Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #8745: Match Ident prefixes to find potential holes #8770

Merged
merged 6 commits into from Apr 23, 2020
Merged

Fix #8745: Match Ident prefixes to find potential holes #8770

merged 6 commits into from Apr 23, 2020

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki self-assigned this Apr 22, 2020
@nicolasstucki nicolasstucki marked this pull request as ready for review April 22, 2020 14:29
liufengyun
liufengyun approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

library/src/scala/internal/quoted/Matcher.scala Outdated Show resolved Hide resolved
library/src/scala/tasty/reflect/CompilerInterface.scala Outdated Show resolved Hide resolved
@nicolasstucki nicolasstucki added this to the 0.24.0-RC1 milestone Apr 22, 2020
liufengyun
liufengyun approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 102284b into scala:master Apr 23, 2020
@nicolasstucki nicolasstucki deleted the fix-#8745 branch April 23, 2020 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter left review comments

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
0.24.0-RC1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicolasstucki @smarter @liufengyun