Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement auto tupling of function arguments #898

Merged
merged 7 commits into from
Feb 18, 2016
Merged

Implement auto tupling of function arguments #898

merged 7 commits into from
Feb 18, 2016

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Oct 31, 2015

Based on #887. Implements SIP #897. Review by @retronym?

@odersky
Copy link
Contributor Author

odersky commented Nov 17, 2015

@retronym Unfortunately your comments were eaten by the rebase. I got the comment about call-by-name parameters. Was there anything else I should look at?

@retronym
Copy link
Member

@odersky Can you find them in your email archives (search for "[dotty] Implement auto uncurry"). I don't get email notifications of my own comments, and I can't find them on commits in your previous branch, either: master...0b8737

@retronym
Copy link
Member

Oh, it looks like I made my comments on #897.

@odersky
Copy link
Contributor Author

odersky commented Nov 18, 2015

Thanks for digging them out Jason! I'll remember the e-mail trick for next
time.

  • Martin

On Wed, Nov 18, 2015 at 5:06 AM, Jason Zaugg notifications@github.com
wrote:

Oh, it looks like I made my comments on #897
#897.

—
Reply to this email directly or view it on GitHub
#898 (comment).

Martin Odersky
EPFL

@odersky odersky changed the title Implement auto uncurry Implement auto tupling of function arguments Feb 16, 2016
@odersky
Auto-uncurry n-ary functions.
29104c9 
Implements SIP scala#897.
@odersky
Add more pos and neg tests
62a526e 
Tests suggested by @retronym's comments on issue scala#897.
@odersky
Fix merge error
81b5f84
@odersky
Turn println into log
e5f8697
@odersky
Strengthen requirement for auto-tupling
06bfbd3 
Was: corresponding parameter types "are compatible".
Now: corresponding parameter types "conform".

This avoids the inconsistency mentioned by @retronym in scala#897.
@odersky
Untuple using def not val.
1729676 
As retronym noted on scala#897, `val` forces to early.
@odersky
Fix pos test
4ceb3e7 
Former test no longer allowed after conforms/compatible change.
@odersky
Copy link
Contributor Author

odersky commented Feb 18, 2016

I don't think we see further reviewer comments. Merging.

odersky added a commit that referenced this pull request Feb 18, 2016
@odersky
Merge pull request #898 from dotty-staging/add/auto-uncurry
0afccf5 
Implement auto tupling of function arguments
@odersky odersky merged commit 0afccf5 into scala:master Feb 18, 2016
@allanrenucci allanrenucci deleted the add/auto-uncurry branch December 14, 2017 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@odersky @retronym