Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segmentation tab #2726

Merged
merged 4 commits into from
Jun 12, 2018
Merged

Fix segmentation tab #2726

merged 4 commits into from
Jun 12, 2018

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Jun 11, 2018

The segmentation value was always requested for zoomstep 0. If there weren't buckets at the requested location, no value could be found. This PR ensures that the value is requested for the current zoomstep (which mirrors the rendered data)

Mailable description of changes:

  • Bug fix: Cell IDs are shown in the segmentation tab for all zoomsteps now
  • The shortcut to copy the currently hovered cell id (CTRL + I) works in non-volume-tracings, too.

URL of deployed dev instance (used for testing):

Steps to test:

  • hover cells in datasets/tracings with segmentation (view, skeleton trace, volume trace) and use shortcut ctrl + I to copy the id
  • open a dataset/tracing without segmentation and ensure that the shortcut doesn't crash (should be a noop)

Issues:


  • Ready for review

@daniel-wer
Copy link
Member

The shortcut works well for me, however, I still feel like the reported segment IDs are not correct, when in another zoomstep than 0. Zoom out a little bit until the "downsampled" warning is displayed and then hover around in a cell. Most of the times, this will display a lot of different segment IDs in the segmentation tab for me, although the highlighted cell is always the same. :/

@daniel-wer
Copy link
Member

I can demonstrate if you have trouble to reproduce :)

Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the voxelIndex computation (by using the correct resolution), works well now :)

@philippotto philippotto merged commit 58209ed into master Jun 12, 2018
@fm3 fm3 deleted the fix-segmentation-tab branch June 13, 2018 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation tab doesn't always show correct values
2 participants