add optional width and height params to thumbnail api. increase default to 400x400 #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippotto
approved these changes
Jun 14, 2018
| def imageFromCacheIfPossible(dataSet: DataSet) = { | ||
| val width = Math.limit(w.getOrElse(DefaultThumbnailWidth), 1, MaxThumbnailHeight) | ||
| val height = Math.limit(h.getOrElse(DefaultThumbnailHeight), 1, MaxThumbnailHeight) | ||
| // We don't want all images to expire at the same time. Therefore, we add a day of randomness, hence the 1 day |
There was a problem hiding this comment.
I know it's been like that before, but wouldn't the comment make more sense before line 58?
|
|
||
| def limit[T](x: T, lower: T, upper: T)(implicit num: Numeric[T]): T = { |
There was a problem hiding this comment.
I haven't heard of limit for this usecase before and would have rather used clamp. But maybe I'm missing some street knowledge here :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mailable description of changes:
URL of deployed dev instance (used for testing):
Steps to test:
/api/datasets/:dataSetName/layers/:layer/thumbnail?w=<Int>&h=<Int>Issues: