Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Refreshing of Expired Datastore Tokens #3633

Merged
merged 9 commits into from
Jan 21, 2019
Merged

Fix Refreshing of Expired Datastore Tokens #3633

merged 9 commits into from
Jan 21, 2019

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jan 16, 2019 •
edited
Loading

Thank you @philippotto for the debugging help :)

Steps to test:

  • in application.conf, set silhouette.tokenAuthenticator.dataStoreExpiry = 1 minute
  • trace some, wait a minute, trace some more
  • new token should be requested, saving should succeed

Issues:

@fm3 fm3 requested a review from philippotto January 16, 2019 14:52
@fm3 fm3 self-assigned this Jan 16, 2019
philippotto
philippotto approved these changes Jan 16, 2019
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@fm3
Copy link
Member Author

fm3 commented Jan 16, 2019 •
edited
Loading

Do you know why eslint now says
302:20 error Expected the Promise rejection reason to be an Error prefer-promise-reject-errors? It was not an Error object before this change, was it? Why complain now? What’s the best way to handle this?

@fm3 fm3 merged commit 4865164 into master Jan 21, 2019
@fm3 fm3 deleted the refresh-datastore-tokens branch January 21, 2019 12:13
@fm3 fm3 mentioned this pull request Feb 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@fm3 fm3

Labels
backend bug frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datastore tokens expire, saving fails without good message
2 participants
@fm3 @philippotto