Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify segementation and color layers #4232

Merged
merged 8 commits into from
Aug 21, 2019

Conversation

MichaelBuessemeyer
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer commented Aug 14, 2019

This PR unifies the UI and its behaviour of segmentation and color layers in the dataset settings.

URL of deployed dev instance (used for testing):

Steps to test:

  • open any dataset and check the following for a color layer and the segmentation layer:
    • the switch button should disable and hide the settings. It should also make the layer invisible in the viewports.
    • all options should work as before (e.g. the opacity option)
    • the color layer should have the color option, the segmentation layer should not.
    • the segmentation layer should additionally have the option "Highlight Hovered Cells".
    • both layers should have their name and element class at the top of their section in the settings.
    • the find data button should work for all layers
      edit: not for segmentations layers

Issues:


@MichaelBuessemeyer
Copy link
Contributor Author

@philippotto This PR is ready for your review. Please tell me what you think of my way of realizing this problem and how to maybe simplify the solution :)

@MichaelBuessemeyer
Copy link
Contributor Author

MichaelBuessemeyer commented Aug 20, 2019

@philippotto Could you please review this PR?
Please note that "find my data" is not working for segmentation layers as issue #4204 is still in my todo list :)

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff! 🍬 See my few comments for feedback :)

@MichaelBuessemeyer MichaelBuessemeyer merged commit fe30714 into master Aug 21, 2019
@philippotto philippotto deleted the unify-segementation-and-color-layers branch June 14, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify handling of segmentation and color layer in settings
2 participants