Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sharing token from URL for sharing links if it exists #6438

Merged
merged 5 commits into from
Sep 6, 2022

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Aug 31, 2022

URL of deployed dev instance (used for testing):

Steps to test:

  • open a private dataset
  • create a sharing link (A)
  • open that link in an incognito window
  • click the share button -> the copied url should contain the same token as in (A)

Issues:


(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Aug 31, 2022
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, did this work for you during testing? For me, the copied link in the incognito tab doesn't contain a token, neither for a shared dataset nor for an annotation.

@philippotto
Copy link
Member Author

Hmm, did this work for you during testing? For me, the copied link in the incognito tab doesn't contain a token, neither for a shared dataset nor for an annotation.

Sorry for the trouble! It worked for me when I opened the PR, but apparently I must have been logged in when I tried to acquire the link. Maybe I didn't use incognito or I was already logged-in in my incognito session (since chrome only supports one incognito session at the same time).

Now it should work :)

Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm now 👍

@philippotto philippotto enabled auto-merge (squash) September 6, 2022 11:24
@philippotto philippotto merged commit f92c355 into master Sep 6, 2022
@philippotto philippotto deleted the reuse-url-token-for-sharing branch September 6, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants